fix(env): frontend catalog names must be storage-node ids; push script survives mDNS serials - #718
Merged
Merged
Conversation
…t survives mDNS serials The frontend's bundled dsm_env_config.toml named the Alibaba fleet us-west-1a-N — descriptive labels, not the nodes' [node] id values. The catalog name is the member id hashed into storage_set_id, so a device running the bundled default computed a set id no node belongs to and every settlement-slot claim was refused (observed on the two-device e2e: 0/3 accepted). Renamed to dsm-node-N and carried over the warning comment from scripts/dsm_env_config.alibaba.toml, which already documented exactly this failure. push_env_override.sh split 'adb devices' output on whitespace, which truncates wireless (mDNS) serials containing spaces into serials adb -s cannot resolve, so pushes to wirelessly connected devices failed. Devices are now addressed by transport id (adb -t), which is a plain integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two rig-blocking defects found during the two-device end-to-end validation:
Bundled frontend catalog used descriptive names, not member ids.
dsm_client/frontend/public/dsm_env_config.tomlnamed the Alibaba nodesus-west-1a-N. The catalognameis the canonical storage-set member id — it is hashed into thestorage_set_ida vault is born under and checked against the node'sx-dsm-node-idecho. A device on the bundled default computed a set id no node belongs to, so every settlement-slot claim was refused (observed live:0/3 accepted, settlement fail-closed).scripts/dsm_env_config.alibaba.tomlalready documents exactly this footgun; the bundled default now matches it (dsm-node-N) and carries the same warning comment.push_env_override.shtruncated wireless adb serials. mDNS serials contain spaces (adb-XXXX-yyyy (2)._adb-tls-connect._tcp); word-splitting produced serialsadb -scannot resolve, so config pushes to wirelessly connected devices failed. The script now addresses devices by transport id (adb -t), a plain integer, at all 18 call sites.Validation
2 1 3.zsh -nclean.[storage_set]config took the two-device e2e from0/3 acceptedto a settled swap and a byte-identical two-devicedlv.composeVaultverdict.